[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 4/5] slirp: fix leak
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v5 4/5] slirp: fix leak |
Date: |
Thu, 4 May 2017 02:38:45 +0400 |
Spotted by ASAN:
/x86_64/hmp/pc-0.12:
=================================================================
==22538==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 224 byte(s) in 1 object(s) allocated from:
#0 0x7f0f63cdee60 in malloc (/lib64/libasan.so.3+0xc6e60)
#1 0x556f11ff32d7 in tcp_newtcpcb
/home/elmarco/src/qemu/slirp/tcp_subr.c:250
#2 0x556f11fdb1d1 in tcp_listen /home/elmarco/src/qemu/slirp/socket.c:688
#3 0x556f11fca9d5 in slirp_add_hostfwd
/home/elmarco/src/qemu/slirp/slirp.c:1052
#4 0x556f11f8db41 in slirp_hostfwd /home/elmarco/src/qemu/net/slirp.c:506
#5 0x556f11f8dd83 in hmp_hostfwd_add /home/elmarco/src/qemu/net/slirp.c:535
There might be a better way to fix this, but calling slirp tcp_close()
doesn't work.
Signed-off-by: Marc-André Lureau <address@hidden>
---
slirp/socket.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/slirp/socket.c b/slirp/socket.c
index 86927722e1..3b49a69a93 100644
--- a/slirp/socket.c
+++ b/slirp/socket.c
@@ -100,6 +100,9 @@ sofree(struct socket *so)
if(so->so_next && so->so_prev)
remque(so); /* crashes if so is not in a queue */
+ if (so->so_tcpcb) {
+ free(so->so_tcpcb);
+ }
free(so);
}
--
2.12.0.191.gc5d8de91d
- [Qemu-devel] [PATCH v5 0/5] Memory leak fixes, Marc-André Lureau, 2017/05/03
- [Qemu-devel] [PATCH v5 2/5] audio: fix capture buffer leaks, Marc-André Lureau, 2017/05/03
- [Qemu-devel] [PATCH v5 3/5] audio: fix WAVState leak, Marc-André Lureau, 2017/05/03
- [Qemu-devel] [PATCH v5 4/5] slirp: fix leak,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v5 5/5] dump: fix memory_mapping_filter leak, Marc-André Lureau, 2017/05/03
- Re: [Qemu-devel] [PATCH v5 0/5] Memory leak fixes, Marc-André Lureau, 2017/05/03
- Re: [Qemu-devel] [PATCH v5 0/5] Memory leak fixes, no-reply, 2017/05/03
- Re: [Qemu-devel] [PATCH v5 0/5] Memory leak fixes, Alex Bennée, 2017/05/04
- Re: [Qemu-devel] [PATCH v5 0/5] Memory leak fixes, Paolo Bonzini, 2017/05/06