Re: [Qemu-devel] [PATCH 5/8] target/m68k: optimize bcd_flags() using extract op

[Laurent Vivier]

Le 10/05/2017 à 22:05, Philippe Mathieu-Daudé a écrit :
> Applied using Coccinelle script.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  target/m68k/translate.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index 9f60fbc0db..babb9e2c5b 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -1463,8 +1463,7 @@ static void bcd_flags(TCGv val)
>      tcg_gen_andi_i32(QREG_CC_C, val, 0x0ff);
>      tcg_gen_or_i32(QREG_CC_Z, QREG_CC_Z, QREG_CC_C);
>  
> -    tcg_gen_shri_i32(QREG_CC_C, val, 8);
> -    tcg_gen_andi_i32(QREG_CC_C, QREG_CC_C, 1);
> +    tcg_gen_extract_i32(QREG_CC_C, val, 8, 1);
>  
>      tcg_gen_mov_i32(QREG_CC_X, QREG_CC_C);
>  }
> 

Acked-by: Laurent Vivier <address@hidden>