[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/4] vga: fix display update region calculation
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 4/4] vga: fix display update region calculation |
Date: |
Thu, 11 May 2017 16:43:39 +0200 |
vga display update mis-calculated the region for the dirty bitmap
snapshot in case the scanlines are padded. This can triggere an
assert in cpu_physical_memory_snapshot_get_dirty().
Fixes: fec5e8c92becad223df9d972770522f64aafdb72
Reported-by: Kevin Wolf <address@hidden>
Reported-by: 李强 <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden
---
hw/display/vga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/vga.c b/hw/display/vga.c
index b2516c8d21..dcc95f88e2 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -1630,7 +1630,7 @@ static void vga_draw_graphic(VGACommonState *s, int
full_update)
if (!full_update) {
vga_sync_dirty_bitmap(s);
snap = memory_region_snapshot_and_clear_dirty(&s->vram, addr1,
- bwidth * height,
+ line_offset * height,
DIRTY_MEMORY_VGA);
}
--
2.9.3
- [Qemu-devel] [PULL 0/4] make display updates thread safe, batch #2, Gerd Hoffmann, 2017/05/11
- [Qemu-devel] [PULL 1/4] cg3: make display updates thread safe, Gerd Hoffmann, 2017/05/11
- [Qemu-devel] [PULL 2/4] tcx: make display updates thread safe, Gerd Hoffmann, 2017/05/11
- [Qemu-devel] [PULL 4/4] vga: fix display update region calculation,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 3/4] sm501: make display updates thread safe, Gerd Hoffmann, 2017/05/11
- Re: [Qemu-devel] [PULL 0/4] make display updates thread safe, batch #2, Stefan Hajnoczi, 2017/05/15