[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 17/18] block: remove all encryption handling
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v6 17/18] block: remove all encryption handling APIs |
Date: |
Thu, 11 May 2017 16:49:28 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 25 Apr 2017 05:38:57 PM CEST, Daniel P. Berrange wrote:
> @@ -220,7 +220,12 @@ static int qcow_open(BlockDriverState *bs, QDict
> *options, int flags,
> goto fail;
> }
> bs->encrypted = true;
> - bs->valid_key = true;
> + } else {
> + if (encryptfmt) {
> + error_setg(errp, "No encryption in image header, but options "
> + "specified format '%s'", encryptfmt);
> + goto fail;
> + }
You need to set a return value here, else it's undefined.
Berto
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v6 17/18] block: remove all encryption handling APIs,
Alberto Garcia <=