qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg op using tcg_gen_extract()
Date: Thu, 11 May 2017 23:04:35 -0300

>> Is this script likely to be rerun in the future?  If yes, keeping it in
>> scripts/coccinelle/ is a good idea.  If no, I recommend to store it in
>> the commit message instead.
>
>
> It is unlikely to be rerun in the future, at least for this specific pattern. 
> But it can be easily adapted for another TCG optimization.
>
> I could not find much documentation about how to do a such script using 
> Python, except on a thread [1]. If it is documented enough I think it is 
> worth to keep it.
>
> About putting it in each commit message, it is now 3 times bigger than the 
> patch it generates!
>
> Regards,
>
> Phil.

I missed this thread ref:

[1] https://github.com/coccinelle/coccinelle/issues/86



reply via email to

[Prev in Thread] Current Thread [Next in Thread]