Re: [Qemu-devel] [PATCH 00/17] qobject/qapi: add uint type

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 00/17] qobject/qapi: add uint type
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
b371cbd qobject: move dump_qobject() from block/ to qobject/
bfd6fc7 RFC: qdict: add uint
dcd5370 Use uint property getter/setter where appropriate
143e214 acpi: fix s3/s4 disabled type
d99e973 qdev: use appropriate getter/setters type
db1dfea qdev: use int and uint properties as appropriate
16017fd object: use more specific property type names
741b10f object: add uint property setter/getter
b3804bd qnum: fix get_int() with values > INT64_MAX
2aba7fc qapi: update the qobject visitor to use QUInt
5e637e4 json: learn to parse uint64 numbers
03c3c0a qnum: add uint type
f9011a3 qapi: remove promote_int
755c246 qapi: merge QInt and QFloat in QNum
4d37032 tests: remove alt num-int cases
e9722ac object: fix potential leak in getters
988cb53 qdev: remove PropertyInfo.qtype field

=== OUTPUT BEGIN ===
Checking PATCH 1/17: qdev: remove PropertyInfo.qtype field...
Checking PATCH 2/17: object: fix potential leak in getters...
Checking PATCH 3/17: tests: remove alt num-int cases...
Checking PATCH 4/17: qapi: merge QInt and QFloat in QNum...
ERROR: do not use C99 // comments
#1885: FILE: tests/check-qnum.c:35:
+    // destroy doesn't exit yet

ERROR: do not use C99 // comments
#1900: FILE: tests/check-qnum.c:50:
+    // destroy doesn't exit yet

total: 2 errors, 0 warnings, 1766 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/17: qapi: remove promote_int...
Checking PATCH 6/17: qnum: add uint type...
ERROR: do not use C99 // comments
#152: FILE: tests/check-qnum.c:50:
+    // destroy doesn't exit yet

total: 1 errors, 0 warnings, 182 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/17: json: learn to parse uint64 numbers...
Checking PATCH 8/17: qapi: update the qobject visitor to use QUInt...
Checking PATCH 9/17: qnum: fix get_int() with values > INT64_MAX...
Checking PATCH 10/17: object: add uint property setter/getter...
Checking PATCH 11/17: object: use more specific property type names...
Checking PATCH 12/17: qdev: use int and uint properties as appropriate...
Checking PATCH 13/17: qdev: use appropriate getter/setters type...
Checking PATCH 14/17: acpi: fix s3/s4 disabled type...
Checking PATCH 15/17: Use uint property getter/setter where appropriate...
Checking PATCH 16/17: RFC: qdict: add uint...
Checking PATCH 17/17: qobject: move dump_qobject() from block/ to qobject/...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden