qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/12] migration: Move colo.h to migration/


From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH 05/12] migration: Move colo.h to migration/
Date: Mon, 15 May 2017 13:04:36 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

"Dr. David Alan Gilbert" <address@hidden> wrote:
D> * Juan Quintela (address@hidden) wrote:
>> There are functions only used by migration code.
>
> That's only mostly true; see the current 'integrate colo frame with
> block replication and net compare' series (posted 22nd April).
> That adds colo_handle_shutdown to this header and calls it from vl.c
> ( https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg03901.html )
> where should that go?

Dropped.

It compiled, but who knows O:-)

> There's also a net/colo.h as well, so using the
>   #include "colo.h" in migration is correct but that's
> really scary when there are two files of the same name.

Yeap, it is scary ...



reply via email to

[Prev in Thread] Current Thread [Next in Thread]