[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 3/4] spapr: Make h_register_process_table
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 3/4] spapr: Make h_register_process_table hcall flags global |
Date: |
Mon, 22 May 2017 12:41:18 +1000 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Sun, May 21, 2017 at 08:48:42PM +0200, Laurent Vivier wrote:
> On 19/05/2017 07:40, Bharata B Rao wrote:
> > The flags used in h_register_process_table hcall are needed in spapr.c
> > and hence move them to a header file. While doing so, give them
> > slightly specific names.
> >
> > Signed-off-by: Bharata B Rao <address@hidden>
> > Reviewed-by: David Gibson <address@hidden>
> > ---
> > hw/ppc/spapr_hcall.c | 31 ++++++++++++++-----------------
> > include/hw/ppc/spapr.h | 10 ++++++++++
> > 2 files changed, 24 insertions(+), 17 deletions(-)
> >
> > diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> > index cea5d99..3915e6f 100644
> > --- a/hw/ppc/spapr_hcall.c
> > +++ b/hw/ppc/spapr_hcall.c
> > @@ -921,13 +921,6 @@ static void
> > spapr_check_setup_free_hpt(sPAPRMachineState *spapr,
> > return;
> > }
> >
> > -#define FLAGS_MASK 0x01FULL
> > -#define FLAG_MODIFY 0x10
> > -#define FLAG_REGISTER 0x08
> > -#define FLAG_RADIX 0x04
> > -#define FLAG_HASH_PROC_TBL 0x02
> > -#define FLAG_GTSE 0x01
> > -
> ...
> > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
> > index e581c4a..588872a 100644
> > --- a/include/hw/ppc/spapr.h
> > +++ b/include/hw/ppc/spapr.h
> > @@ -685,4 +685,14 @@ int spapr_rng_populate_dt(void *fdt);
> >
> > void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg);
> >
> > +/*
> > + * Defines for flag value used in H_REGISTER_PROC_TBL hcall.
> > + */
> > +#define SPAPR_PROC_TABLE_MASK 0x01FULL
> > +#define SPAPR_PROC_TABLE_MODIFY 0x10
> > +#define SPAPR_PROC_TABLE_REGISTER 0x08
> > +#define SPAPR_PROC_TABLE_RADIX 0x04
> > +#define SPAPR_PROC_TABLE_HPT_PT 0x02
> > +#define SPAPR_PROC_TABLE_GTSE 0x01
>
> I think it should be cleaner if you use 0x1fULL
I agree, but looking at the new version of the final patch, I don't
think this patch will actually be necessary any more.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [RFC PATCH v2 0/4] ppc/spapr: Fix migration of radix guests, Bharata B Rao, 2017/05/19
- [Qemu-devel] [RFC PATCH v2 2/4] spapr: Unregister HPT savevm handlers for radix guests, Bharata B Rao, 2017/05/19
- [Qemu-devel] [RFC PATCH v2 3/4] spapr: Make h_register_process_table hcall flags global, Bharata B Rao, 2017/05/19
- [Qemu-devel] [RFC PATCH v2 4/4] spapr: Fix migration of Radix guests, Bharata B Rao, 2017/05/19
- Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v2 4/4] spapr: Fix migration of Radix guests, Suraj Jitindar Singh, 2017/05/22