[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 18/24] shippable: do not initialize submodule
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v3 18/24] shippable: do not initialize submodules automatically |
Date: |
Mon, 22 May 2017 15:10:30 +0100 |
User-agent: |
mu4e 0.9.19; emacs 25.2.50.1 |
Philippe Mathieu-Daudé <address@hidden> writes:
> instead do it in the 'ci' target when needed.
>
> for mips64el-softmmu target:
> use dtc submodule if distrib packages are too old.
>
> example with outdated libfdt on mips64el-softmmu target (required is >=
> 1.4.2):
> # dpkg-query --showformat='${Version}\n' --show libfdt-dev
> 1.4.0+dfsg-1
>
> shippable output:
> ----------------
> LINK mips64el-softmmu/qemu-system-mips64el
> ../hw/core/loader-fit.o: In function `load_fit':
> /root/src/github.com/philmd/qemu/hw/core/loader-fit.c:278: undefined
> reference to `fdt_first_subnode'
> /root/src/github.com/philmd/qemu/hw/core/loader-fit.c:286: undefined
> reference to `fdt_next_subnode'
> /root/src/github.com/philmd/qemu/hw/core/loader-fit.c:277: undefined
> reference to `fdt_first_subnode'
> collect2: error: ld returned 1 exit status
> Makefile:201: recipe for target 'qemu-system-mips64el' failed
> make[1]: *** [qemu-system-mips64el] Error 1
> Makefile:327: recipe for target 'subdir-mips64el-softmmu' failed
> make: *** [subdir-mips64el-softmmu] Error 2
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> .shippable.yml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/.shippable.yml b/.shippable.yml
> index 1e3ae35dd9..46adfa030f 100644
> --- a/.shippable.yml
> +++ b/.shippable.yml
> @@ -1,4 +1,6 @@
> language: c
> +git:
> + submodules: false
> env:
> global:
> - LC_ALL=C
> @@ -19,5 +21,13 @@ build:
> options: "-e HOME=/root"
> ci:
> - unset CC
> + # some targets require newer up to date packages, for example
> TARGET_LIST matching
> + #
> aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64el-softmmu)
> + # see the configure script:
> + # error_exit "DTC (libfdt) version >= 1.4.2 not present. Your
> options:"
> + # " (1) Preferred: Install the DTC (libfdt) devel package"
> + # " (2) Fetch the DTC submodule, using:"
> + # " git submodule update --init dtc"
> + - dpkg --compare-versions `dpkg-query --showformat='${Version}' --show
> libfdt-dev` ge 1.4.2 || git submodule update --init dtc
> - ./configure ${QEMU_CONFIGURE_OPTS} --target-list=${TARGET_LIST}
> - make -j$(($(getconf _NPROCESSORS_ONLN) + 1))
--
Alex Bennée
- [Qemu-devel] [PATCH v3 15/24] docker: add powerpc build target, (continued)
- [Qemu-devel] [PATCH v3 15/24] docker: add powerpc build target, Philippe Mathieu-Daudé, 2017/05/20
- [Qemu-devel] [PATCH v3 13/24] docker: add extra libs to s390x target to extend codebase coverage, Philippe Mathieu-Daudé, 2017/05/20
- [Qemu-devel] [PATCH v3 14/24] docker: add mipsel build target, Philippe Mathieu-Daudé, 2017/05/20
- [Qemu-devel] [PATCH v3 16/24] shippable: use C locale to simplify console output, Philippe Mathieu-Daudé, 2017/05/20
- [Qemu-devel] [PATCH v3 17/24] shippable: build using all available cpus, Philippe Mathieu-Daudé, 2017/05/20
- [Qemu-devel] [PATCH v3 18/24] shippable: do not initialize submodules automatically, Philippe Mathieu-Daudé, 2017/05/20
- Re: [Qemu-devel] [PATCH v3 18/24] shippable: do not initialize submodules automatically,
Alex Bennée <=
- [Qemu-devel] [PATCH v3 20/24] shippable: add armeb-linux-user target, Philippe Mathieu-Daudé, 2017/05/20
- [Qemu-devel] [PATCH v3 21/24] shippable: add powerpc target, Philippe Mathieu-Daudé, 2017/05/20
- [Qemu-devel] [PATCH v3 23/24] MAINTAINERS: add Shippable automation platform URL, Philippe Mathieu-Daudé, 2017/05/20
- [Qemu-devel] [PATCH v3 24/24] MAINTAINERS: self-appoint me as reviewer in build/test automation, Philippe Mathieu-Daudé, 2017/05/20
- [Qemu-devel] [PATCH v3 19/24] shippable: be verbose while building docker images, Philippe Mathieu-Daudé, 2017/05/20
- [Qemu-devel] [PATCH v3 22/24] shippable: add mipsel target, Philippe Mathieu-Daudé, 2017/05/20