[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new T
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock |
Date: |
Tue, 23 May 2017 12:48:51 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 2017-05-22 20:02, Richard Henderson wrote:
> Previously, helper_ex would construct the insn and then implement
> the insn via direct calls other helpers. This was sufficient to
> boot Linux but that is all.
>
> It is easy enough to go the whole nine yards by stashing state for
> EXECUTE within the cpu, and then relying on a new TB to be created
> that properly and completely interprets the insn.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/s390x/cpu.h | 4 +-
> target/s390x/helper.h | 2 +-
> target/s390x/insn-data.def | 4 +-
> target/s390x/machine.c | 19 +++++++
> target/s390x/mem_helper.c | 136
> +++++++++++----------------------------------
> target/s390x/translate.c | 124 +++++++++++++++++++++++++----------------
> 6 files changed, 133 insertions(+), 156 deletions(-)
This looks good on the principle, and finally removes a big hack. That
said it prevent my test system to boot. I haven't investigated why yet.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 00/31] target/s390x unwind patches, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 01/31] target/s390: Use cpu_loop_exit_restore for tlb_fill, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 03/31] target/s390x: Use unwind data for helper_nc, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Richard Henderson, 2017/05/22
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock,
Aurelien Jarno <=
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Richard Henderson, 2017/05/23
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Aurelien Jarno, 2017/05/23
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Richard Henderson, 2017/05/23
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Aurelien Jarno, 2017/05/24
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Richard Henderson, 2017/05/24
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Thomas Huth, 2017/05/23
- Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock, Aurelien Jarno, 2017/05/23
[Qemu-devel] [PATCH 04/31] target/s390x: Use unwind data for helper_xc, Richard Henderson, 2017/05/22