|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 30/31] target/s390x: Implement CSPG |
Date: | Tue, 23 May 2017 09:33:22 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/23/2017 04:12 AM, Aurelien Jarno wrote:
On 2017-05-22 20:03, Richard Henderson wrote:Signed-off-by: Richard Henderson <address@hidden> --- target/s390x/insn-data.def | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 4c91f30..8604847 100644 --- a/target/s390x/insn-data.def +++ b/target/s390x/insn-data.def @@ -838,6 +838,7 @@ #ifndef CONFIG_USER_ONLY /* COMPARE AND SWAP AND PURGE */ D(0xb250, CSP, RRE, Z, r1_32u, ra2, r1_P, 0, csp, 0, MO_TEUL) + D(0xb98a, CSPG, RRE, Z, r1_o, ra2, r1_P, 0, csp, 0, MO_TEQ)CSPG is part of the of the DAT-enhancement facility. I called it DAT_ENH in my local patches to match the name we have in the CPU features.
The translator needs a large overhaul to bring it into line with the (more recently added) facilities infrastructure. We don't currently enforce anything.
But you're also right that I shouldn't just ignore the issue and leave it marked incorrectly.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |