[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 30/33] target/s390x: Fix some helper_ex probl
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v2 30/33] target/s390x: Fix some helper_ex problems |
Date: |
Thu, 25 May 2017 22:50:17 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 2017-05-24 12:22, Richard Henderson wrote:
> (1) The OR of the low bits or R1 into INSN were not being done
> consistently; it was forgotten along all but the SVC path.
It was done for the logical ops assuming the instruction has the
corresponding byte set to 0, as in that case it matches the length
and is passed directly as an argument to the helper.
> (2) The setting of ILEN was wrong on SVC path for EXRL.
> (3) The data load for ICM read too much.
>
> Fix these by consolidating data load at the beginning, using
> get_ilen to control the number of bytes loaded, and ORing in
> the byte from R1. Use extract64 from the full aligned insn
> to extract arguments.
>
> Pass in ILEN rather than RET as the more natural way to give
> the required data along the SVC path.
>
> Modify ENV->CC_OP directly rather than include it in the
> functional interface.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/s390x/helper.h | 2 +-
> target/s390x/mem_helper.c | 135
> +++++++++++++++++++++++++---------------------
> target/s390x/translate.c | 8 +--
> 3 files changed, 78 insertions(+), 67 deletions(-)
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v2 23/33] target/s390x: Use unwind data for helper_lctlg, (continued)
- [Qemu-devel] [PATCH v2 23/33] target/s390x: Use unwind data for helper_lctlg, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 24/33] target/s390x: Use unwind data for helper_lctl, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 26/33] target/s390x: Use unwind data for helper_testblock, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 27/33] target/s390x: Use unwind data for helper_tprot, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 25/33] target/s390x: Use unwind data for helper_stctl, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 28/33] target/s390x: Use unwind data for helper_lra, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 31/33] target/s390x: Fix EXECUTE with R1==0, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 30/33] target/s390x: Fix some helper_ex problems, Richard Henderson, 2017/05/24
- Re: [Qemu-devel] [PATCH v2 30/33] target/s390x: Fix some helper_ex problems,
Aurelien Jarno <=
- [Qemu-devel] [PATCH v2 29/33] target/s390x: Use unwind data for helper_mvcs/mvcp, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 32/33] target/s390x: Use atomic operations for COMPARE SWAP PURGE, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 33/33] target/s390x: Implement CSPG, Richard Henderson, 2017/05/24