Re: [Qemu-devel] [PATCH v2] pci: Set err to errp directly rather than through error_porpagate()

[Mao Zhongyi]

On 05/26/2017 09:33 PM, Eric Blake wrote:
> On 05/26/2017 06:58 AM, Mao Zhongyi wrote:
>
> In the subject: s/porpagate/propagate/
>
> > ioh3420_interrupts_init() and its callers rp_realize() fill error
> > message to local_err, then propagate it to errp by error_porpagate(),
>
> and again

OK, I see.
Thanks

> > which's not necessary. So eliminate it and pass errp directly instead
>
> s/which's/which is/ (English does not have the abbreviation which's)

Thanks for your kindly remind. I think that this problem will not
happen again. :)

> > of local_err. Of course, error_propagate() also has been removed.
> >
> > Signed-off-by: Mao Zhongyi <address@hidden>
> > ---
> > v2:
> > * Drop the part of wrong handling that ignored the fact that if
> >   pci_qdev_realize()'s caller pass errp = NULL.
>
> The code portion is fine, so with the commit message fixed (which a
> maintainer might do without needing you to send a v3),
> Reviewed-by: Eric Blake <address@hidden>

I am very glad to hear that.
I will fix it again in the v3. After all, it's not good to bother
others.

Thanks a lot.
Mao