[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/29] target/s390x: remove some Linux assump
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/29] target/s390x: remove some Linux assumptions from IPTE |
Date: |
Tue, 30 May 2017 13:19:35 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 2017-05-30 10:20, Thomas Huth wrote:
> On 29.05.2017 21:24, Aurelien Jarno wrote:
> > Signed-off-by: Aurelien Jarno <address@hidden>
> > ---
> > target/s390x/cpu.h | 2 ++
> > target/s390x/mem_helper.c | 17 ++++++++++-------
> > target/s390x/mmu_helper.c | 4 +---
> > 3 files changed, 13 insertions(+), 10 deletions(-)
> >
> > diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
> > index 79235cfa45..d89ad83e71 100644
> > --- a/target/s390x/cpu.h
> > +++ b/target/s390x/cpu.h
> > @@ -1033,6 +1033,8 @@ struct sysib_322 {
> > #define _SEGMENT_ENTRY_RO 0x200 /* page protection bit
> > */
> > #define _SEGMENT_ENTRY_INV 0x20 /* invalid segment table entry
> > */
> >
> > +#define _VADDR_PX 0xff000 /* page index bits
> > */
>
> Even though the other #defines start with an underscore, we should not
> use this for new code anymore. #defines that start with an underscore +
> capital letter are reserved for the C compiler. If you're afraid that
> this "VADDR_PX" is not unique enough, maybe rename it to "MMU_VADDR_PX"
> instead?
Ok, I'll change that, possibly renaming a few other defines.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- Re: [Qemu-devel] [PATCH v2 03/29] target/s390x: implement local-TLB-clearing in IPTE, (continued)
- [Qemu-devel] [PATCH v2 10/29] target/s390x: implement MOVE INVERSE, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 20/29] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 11/29] target/s390x: implement MOVE NUMERICS, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 28/29] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 13/29] target/s390x: implement MOVE ZONES, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 02/29] target/s390x: remove some Linux assumptions from IPTE, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 27/29] target/s390x: implement TEST DECIMAL, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 25/29] target/s390x: implement UNPACK ASCII, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 21/29] target/s390x: implement COMPARE LOGICAL LONG UNICODE, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 23/29] target/s390x: implement PACK ASCII, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 15/29] target/s390x: improve 24-bit and 31-bit addresses write, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 24/29] target/s390x: implement PACK UNICODE, Aurelien Jarno, 2017/05/29
- [Qemu-devel] [PATCH v2 18/29] target/s390x: implement COMPARE LOGICAL LONG, Aurelien Jarno, 2017/05/29