[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/19] nbd/server: refactor nbd_trip
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 10/19] nbd/server: refactor nbd_trip |
Date: |
Tue, 30 May 2017 17:23:49 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote:
> - do not goto into switch block from outer block
This sentence didn't quite make sense. Better might be:
- do not use 'goto error_reply' outside a switch to jump into the middle
of the switch's default case label
> - reduce code duplications
s/duplications/duplication/
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> nbd/server.c | 53 ++++++++++++++++++++---------------------------------
> 1 file changed, 20 insertions(+), 33 deletions(-)
>
> @@ -1098,7 +1099,7 @@ static coroutine_fn void nbd_trip(void *opaque)
>
> if (ret < 0) {
> reply.error = -ret;
> - goto error_reply;
> + goto reply;
> }
But this was indeed a case of jumping from before the switch()...
> default:
> LOG("invalid request type (%" PRIu32 ") received", request.type);
> reply.error = EINVAL;
> - error_reply:
> - /* We must disconnect after NBD_CMD_WRITE if we did not
> - * read the payload.
> - */
...into the middle, which, although valid C, is indeed unusual.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/19] nbd errors and traces refactoring, Vladimir Sementsov-Ogievskiy, 2017/05/30
- [Qemu-devel] [PATCH 08/19] nbd/server: get rid of fail: return rc, Vladimir Sementsov-Ogievskiy, 2017/05/30
- [Qemu-devel] [PATCH 07/19] nbd/server: nbd_negotiate: fix error path, Vladimir Sementsov-Ogievskiy, 2017/05/30
- [Qemu-devel] [PATCH 10/19] nbd/server: refactor nbd_trip, Vladimir Sementsov-Ogievskiy, 2017/05/30
- Re: [Qemu-devel] [PATCH 10/19] nbd/server: refactor nbd_trip,
Eric Blake <=
- [Qemu-devel] [PATCH 13/19] nbd/server: return original error codes, Vladimir Sementsov-Ogievskiy, 2017/05/30
- [Qemu-devel] [PATCH 09/19] nbd/server: rename rc to ret, Vladimir Sementsov-Ogievskiy, 2017/05/30
- [Qemu-devel] [PATCH 05/19] nbd/server: refactor nbd_co_receive_request, Vladimir Sementsov-Ogievskiy, 2017/05/30
- [Qemu-devel] [PATCH 12/19] nbd/common: nbd_wr_syncv handle QIO_CHANNEL_ERR_EPIPE, Vladimir Sementsov-Ogievskiy, 2017/05/30
- [Qemu-devel] [PATCH 18/19] nbd/client: refactor TRACE of NBD_MAGIC, Vladimir Sementsov-Ogievskiy, 2017/05/30
- [Qemu-devel] [PATCH 14/19] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT, Vladimir Sementsov-Ogievskiy, 2017/05/30
- [Qemu-devel] [PATCH 02/19] nbd/server: get rid of ssize_t, Vladimir Sementsov-Ogievskiy, 2017/05/30