[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Block migration test
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Block migration test |
Date: |
Thu, 1 Jun 2017 10:59:50 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 31.05.2017 um 19:03 hat Eric Blake geschrieben:
> On 05/31/2017 04:52 AM, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > tests/qemu-iotests/183 | 140
> > +++++++++++++++++++++++++++++++++++++++++++++
> > tests/qemu-iotests/183.out | 46 +++++++++++++++
> > tests/qemu-iotests/group | 1 +
> > 3 files changed, 187 insertions(+)
> > create mode 100755 tests/qemu-iotests/183
> > create mode 100644 tests/qemu-iotests/183.out
>
> > +qemu_comm_method="qmp"
> > +
> > +_launch_qemu \
> > + -drive file="${TEST_IMG}",cache=${CACHEMODE},driver=$IMGFMT,id=disk
>
> Inconsistent use of ${CACHEMODE} vs. $IMGFMT (I prefer the version with
> less typing, but others prefer always using ${}). In both _launch_qemu
> lines. Up to you if you want to tweak it, but either way,
That's what you get for copying the line and then appending one more
option... I'll remove the extra {} for $CACHEMODE.
Kevin
pgp8FJmp2t23e.pgp
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Block migration test,
Kevin Wolf <=