[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/15] char: cast ARRAY_SIZE() as signed to silent wa
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PULL 01/15] char: cast ARRAY_SIZE() as signed to silent warning on empty array |
Date: |
Fri, 2 Jun 2017 11:40:26 +0400 |
From: Philippe Mathieu-Daudé <address@hidden>
chardev/char.c: In function 'chardev_name_foreach':
chardev/char.c:546:19: error: comparison of unsigned expression < 0 is always
false [-Werror=type-limits]
for (i = 0; i < ARRAY_SIZE(chardev_alias_table); i++) {
^
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
chardev/char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char.c b/chardev/char.c
index 4e24dc39af..26607c1c6b 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -841,7 +841,7 @@ chardev_name_foreach(void (*fn)(const char *name, void
*opaque), void *opaque)
object_class_foreach(chardev_class_foreach, TYPE_CHARDEV, false, &fe);
- for (i = 0; i < ARRAY_SIZE(chardev_alias_table); i++) {
+ for (i = 0; i < (int)ARRAY_SIZE(chardev_alias_table); i++) {
fn(chardev_alias_table[i].alias, opaque);
}
}
@@ -887,7 +887,7 @@ Chardev *qemu_chr_new_from_opts(QemuOpts *opts,
return NULL;
}
- for (i = 0; i < ARRAY_SIZE(chardev_alias_table); i++) {
+ for (i = 0; i < (int)ARRAY_SIZE(chardev_alias_table); i++) {
if (g_strcmp0(chardev_alias_table[i].alias, name) == 0) {
name = chardev_alias_table[i].typename;
break;
--
2.13.0.91.g00982b8dd
- [Qemu-devel] [PULL 00/15] chardev patches, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 01/15] char: cast ARRAY_SIZE() as signed to silent warning on empty array,
Marc-André Lureau <=
- [Qemu-devel] [PULL 02/15] char-win: simplify win_chr_read(), Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 03/15] char-win: remove WinChardev.len, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 04/15] char-win: rename win_chr_init/poll win_chr_serial_init/poll, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 05/15] char-win: rename hcom->file, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 06/15] char-win: close file handle except with console, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 07/15] Remove/replace sysemu/char.h inclusion, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 08/15] chardev: move headers to include/chardev, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 09/15] chardev: serial & parallel declaration to own headers, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 10/15] be-hci: use backend functions, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 11/15] char: generalize qemu_chr_write_all(), Marc-André Lureau, 2017/06/02