[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/8] virtio-serial-bus: Unset hotplug handler when un
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 1/8] virtio-serial-bus: Unset hotplug handler when unrealize |
Date: |
Fri, 2 Jun 2017 19:34:29 +0300 |
From: Ladi Prosek <address@hidden>
Virtio serial device controls the lifetime of virtio-serial-bus and
virtio-serial-bus links back to the device via its hotplug-handler
property. This extra ref-count prevents the device from getting
finalized, leaving the VirtIODevice memory listener registered and
leading to use-after-free later on.
This patch addresses the same issue as Fam Zheng's
"virtio-scsi: Unset hotplug handler when unrealize"
only for a different virtio device.
Cc: address@hidden
Signed-off-by: Ladi Prosek <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
---
hw/char/virtio-serial-bus.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index d797a67..aa9c11a 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -1121,6 +1121,9 @@ static void virtio_serial_device_unrealize(DeviceState
*dev, Error **errp)
timer_free(vser->post_load->timer);
g_free(vser->post_load);
}
+
+ qbus_set_hotplug_handler(BUS(&vser->bus), NULL, errp);
+
virtio_cleanup(vdev);
}
--
MST
- [Qemu-devel] [PULL 0/8] virtio, vhost: fixes, features, Michael S. Tsirkin, 2017/06/02
- [Qemu-devel] [PULL 1/8] virtio-serial-bus: Unset hotplug handler when unrealize,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 2/8] virtio: add virtqueue_alloc_element tracepoint, Michael S. Tsirkin, 2017/06/02
- [Qemu-devel] [PULL 3/8] virtio-serial: fix segfault on disconnect, Michael S. Tsirkin, 2017/06/02
- [Qemu-devel] [PULL 4/8] vhost: propagate errors in vhost_device_iotlb_miss(), Michael S. Tsirkin, 2017/06/02
- [Qemu-devel] [PULL 5/8] vhost: rework IOTLB messaging, Michael S. Tsirkin, 2017/06/02
- [Qemu-devel] [PULL 6/8] vhost-user: add vhost_user to hold the chr, Michael S. Tsirkin, 2017/06/02
- [Qemu-devel] [PULL 7/8] vhost-user: add slave-req-fd support, Michael S. Tsirkin, 2017/06/02
- [Qemu-devel] [PULL 8/8] spec/vhost-user spec: Add IOMMU support, Michael S. Tsirkin, 2017/06/02
- Re: [Qemu-devel] [PULL 0/8] virtio, vhost: fixes, features, Peter Maydell, 2017/06/02