[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/19] nbd/server: add errp to nbd_send_reply()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 16/19] nbd/server: add errp to nbd_send_reply() |
Date: |
Sat, 3 Jun 2017 16:50:12 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> nbd/server.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
>
> - if (nbd_co_send_reply(req, &reply, reply_data_len) < 0) {
> - error_setg(&local_err, "Failed to send reply");
> + if (nbd_co_send_reply(req, &reply, reply_data_len, &local_err) < 0) {
> + error_prepend(&local_err, "Failed to send reply");
In the previous patch, you had a lot of conversions from LOG("message")
to error_prepend(..., "message: ") (note the addition of the ': '
suffix). Is this addition of error_prepend going to come out right?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 16/19] nbd/server: add errp to nbd_send_reply(),
Eric Blake <=