[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket wai
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error |
Date: |
Tue, 6 Jun 2017 16:55:38 -0700 |
On Tue, Jun 6, 2017 at 3:14 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 06/06/2017 18:30, Alistair Francis wrote:
>>>
>>> This is somehow confusing. I don't think it is worth having another
>>> qemu_log_stderr() function rather than using error_report() but this very
>>> call might deserve a comment explaining this unusual use. What do you think?
>>
>> The problem with stderr is that this isn't an error. Some uses of QEMU
>> (inside Eclipse for example) flag everything printed on stderr as red
>> which confuses users that they are seeing an error when they really
>> aren't.
>
> But they are wrong. Would it work for you to work around it, by making
> QEMU use a client (connect) rather than a server (listen) socket?
No, we use QEMU as both so we will always have this issue.
>
>> Also all the uses of this message that I have seen (there are probably
>> others though) stops QEMU until the connection is made, which means it
>> doesn't matter if it is mixed up in console output.
>
> It may not mix up, but it would break programs expecting only console
> output to be on stdout.
Is that something we guarantee that stdout will only ever be program output?
Thanks,
Alistair
>
>> I just think that this message to most users isn't helpful and they
>> probably don't even read it, so printing to stderr seems like a bit
>> much.
>
> I would compare it with dd's output. It goes to stderr even though it's
> not an error.
>
> Paolo
>
- [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Alistair Francis, 2017/06/05
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Philippe Mathieu-Daudé, 2017/06/05
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Marc-André Lureau, 2017/06/06
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Philippe Mathieu-Daudé, 2017/06/06
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Alistair Francis, 2017/06/06
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Paolo Bonzini, 2017/06/06
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error,
Alistair Francis <=
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Markus Armbruster, 2017/06/07
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Alistair Francis, 2017/06/07
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Markus Armbruster, 2017/06/08
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Alistair Francis, 2017/06/08
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Markus Armbruster, 2017/06/08
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Alistair Francis, 2017/06/08
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Markus Armbruster, 2017/06/09
- Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error, Alistair Francis, 2017/06/27