[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 08/70] target/s390x: Use unwind data for helper_cl
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL v2 08/70] target/s390x: Use unwind data for helper_clc |
Date: |
Tue, 6 Jun 2017 17:30:17 -0700 |
Reviewed-by: Aurelien Jarno <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/s390x/mem_helper.c | 29 +++++++++++++++++------------
target/s390x/translate.c | 1 -
2 files changed, 17 insertions(+), 13 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 78a9ac1..50689bb 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -233,32 +233,37 @@ void HELPER(mvc)(CPUS390XState *env, uint32_t l, uint64_t
dest, uint64_t src)
}
/* compare unsigned byte arrays */
-uint32_t HELPER(clc)(CPUS390XState *env, uint32_t l, uint64_t s1, uint64_t s2)
+static uint32_t do_helper_clc(CPUS390XState *env, uint32_t l, uint64_t s1,
+ uint64_t s2, uintptr_t ra)
{
- int i;
- unsigned char x, y;
- uint32_t cc;
+ uint32_t i;
+ uint32_t cc = 0;
HELPER_LOG("%s l %d s1 %" PRIx64 " s2 %" PRIx64 "\n",
__func__, l, s1, s2);
+
for (i = 0; i <= l; i++) {
- x = cpu_ldub_data(env, s1 + i);
- y = cpu_ldub_data(env, s2 + i);
+ uint8_t x = cpu_ldub_data_ra(env, s1 + i, ra);
+ uint8_t y = cpu_ldub_data_ra(env, s2 + i, ra);
HELPER_LOG("%02x (%c)/%02x (%c) ", x, x, y, y);
if (x < y) {
cc = 1;
- goto done;
+ break;
} else if (x > y) {
cc = 2;
- goto done;
+ break;
}
}
- cc = 0;
- done:
+
HELPER_LOG("\n");
return cc;
}
+uint32_t HELPER(clc)(CPUS390XState *env, uint32_t l, uint64_t s1, uint64_t s2)
+{
+ return do_helper_clc(env, l, s1, s2, GETPC());
+}
+
/* compare logical under mask */
uint32_t HELPER(clm)(CPUS390XState *env, uint32_t r1, uint32_t mask,
uint64_t addr)
@@ -1237,8 +1242,8 @@ uint32_t HELPER(ex)(CPUS390XState *env, uint32_t cc,
uint64_t v1,
get_address(env, 0, b2, d2), 0);
break;
case 0x500:
- cc = helper_clc(env, l, get_address(env, 0, b1, d1),
- get_address(env, 0, b2, d2));
+ cc = do_helper_clc(env, l, get_address(env, 0, b1, d1),
+ get_address(env, 0, b2, d2), 0);
break;
case 0x600:
cc = do_helper_oc(env, l, get_address(env, 0, b1, d1),
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index a9502cc..c47b818 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -1906,7 +1906,6 @@ static ExitStatus op_clc(DisasContext *s, DisasOps *o)
tcg_gen_qemu_ld64(cc_dst, o->in2, get_mem_index(s));
break;
default:
- potential_page_fault(s);
vl = tcg_const_i32(l);
gen_helper_clc(cc_op, cpu_env, vl, o->addr1, o->in2);
tcg_temp_free_i32(vl);
--
2.9.4
- [Qemu-devel] [PULL v2 00/70] target/s390x tcg patches, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 01/70] target/s390x: Add support for the TEST BLOCK instruction, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 02/70] target/s390x: Use cpu_loop_exit_restore for tlb_fill, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 03/70] target/s390x: Move helper_ex to end of file, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 04/70] target/s390x: Use unwind data for helper_nc, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 05/70] target/s390x: Use unwind data for helper_oc, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 06/70] target/s390x: Use unwind data for helper_xc, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 08/70] target/s390x: Use unwind data for helper_clc,
Richard Henderson <=
- [Qemu-devel] [PULL v2 07/70] target/s390x: Use unwind data for helper_mvc, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 09/70] target/s390x: Use unwind data for helper_clm, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 10/70] target/s390x: Use unwind data for helper_srst, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 11/70] target/s390x: Use unwind data for helper_clst, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 12/70] target/s390x: Use unwind data for helper_mvpg, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 13/70] target/s390x: Use unwind data for helper_mvst, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 14/70] target/s390x: Use unwind data for helper_lam, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 15/70] target/s390x: Use unwind data for helper_stam, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 16/70] target/s390x: Use unwind data for helper_mvcl, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 17/70] target/s390x: Use unwind data for helper_mvcle, Richard Henderson, 2017/06/06