Re: [Qemu-devel] [PATCH 3/5] migration: Create load_setup()/cleanup() methods

[Kevin Wolf]

Am 02.06.2017 um 00:15 hat Juan Quintela geschrieben:
> We need to do things at load time.
> 
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  include/migration/register.h |  2 ++
>  migration/savevm.c           | 31 +++++++++++++++++++++++++++++++
>  2 files changed, 33 insertions(+)
> 
> diff --git a/include/migration/register.h b/include/migration/register.h
> index 8e37185..0862bb8 100644
> --- a/include/migration/register.h
> +++ b/include/migration/register.h
> @@ -42,6 +42,8 @@ typedef struct SaveVMHandlers {
>                                uint64_t *non_postcopiable_pending,
>                                uint64_t *postcopiable_pending);
>      LoadStateHandler *load_state;
> +    int (*load_setup)(QEMUFile *f, void *opaque);
> +    int (*load_cleanup)(void *opaque);
>  } SaveVMHandlers;

I see that you add code to call load_setup(), but don't you want to call
load_cleanup() somewhere, too?

Kevin