[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/11] migration: Split registration functions f
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 03/11] migration: Split registration functions from vmstate.h |
Date: |
Mon, 12 Jun 2017 12:36:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Peter Xu <address@hidden> wrote:
> On Thu, Jun 01, 2017 at 11:29:13PM +0200, Juan Quintela wrote:
>> They are indpendent, and nowadays almost every device register things
>> with qdev->vmsd.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> +
>> +int register_savevm(DeviceState *dev,
>> + const char *idstr,
>> + int instance_id,
>> + int version_id,
>> + SaveStateHandler *save_state,
>> + LoadStateHandler *load_state,
>> + void *opaque);
>
> Looks like this patch needs a rebasing since this function is already
> remove...
>
>> +
>> +int register_savevm_live(DeviceState *dev,
>> + const char *idstr,
>> + int instance_id,
>> + int version_id,
>> + SaveVMHandlers *ops,
>> + void *opaque);
>> +
>> +void unregister_savevm(DeviceState *dev, const char *idstr, void *opaque);
>> +
>> +#endif
>> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
>> index b95c9bb..6de554d 100644
>> --- a/include/migration/vmstate.h
>> +++ b/include/migration/vmstate.h
>> @@ -29,53 +29,8 @@
>>
>> #include "migration/qjson.h"
>>
>> -typedef void SaveStateHandler(QEMUFile *f, void *opaque);
>> typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id);
>
> Should be removed too?
>
> Other than mentioned above:
>
> Reviewed-by: Peter Xu <address@hidden>
Local copy already have this two bits fixed. It is just that I posted
this series before that changes got into upstream.
Later, Juan.
- [Qemu-devel] [PATCH 01/11] migration: Remove MigrationState from migration_channel_incomming(), (continued)
- [Qemu-devel] [PATCH 03/11] migration: Split registration functions from vmstate.h, Juan Quintela, 2017/06/01
- [Qemu-devel] [PATCH 04/11] migration: Move dump_vmsate_json_to_file() to misc.h, Juan Quintela, 2017/06/01
- [Qemu-devel] [PATCH 05/11] migration: Move constants to savevm.h, Juan Quintela, 2017/06/01
- [Qemu-devel] [PATCH 06/11] migration: Commands are only used inside migration.c, Juan Quintela, 2017/06/01
- [Qemu-devel] [PATCH 07/11] migration: ram_control_* are implemented in qemu_file, Juan Quintela, 2017/06/01
- [Qemu-devel] [PATCH 08/11] migration: create global_state.c, Juan Quintela, 2017/06/01