[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: fix incorrect enable return path
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] migration: fix incorrect enable return path |
Date: |
Wed, 14 Jun 2017 09:31:10 +0100 |
User-agent: |
Mutt/1.8.2 (2017-04-18) |
* Peter Xu (address@hidden) wrote:
> 0425dc9 is actually v1 of that patch, but it was accidentally
> merged (while there was a v2). That will cause problem when we try to
> migrate to some old QEMUs when return path is not really there. Let's
> fix it, then squashing this patch with 0425dc9 will be exactly patch
> content of v2.
>
> Fixes: 0425dc9 ("migration: isolate return path on src")
> Signed-off-by: Peter Xu <address@hidden>
> ---
> migration/migration.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 8ef6d6c..f9053b0 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1814,7 +1814,11 @@ static void *migration_thread(void *opaque)
>
> qemu_savevm_state_header(s->to_dst_file);
>
> - if (s->to_dst_file) {
> + /*
> + * If we opened the return path, we need to make sure dst has it
> + * opened as well.
> + */
> + if (s->rp_state.from_dst_file) {
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> /* Now tell the dest that it should open its end so it can reply */
> qemu_savevm_send_open_return_path(s->to_dst_file);
>
> --
> 2.7.4
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK