Re: [Qemu-devel] [PATCH 0/5] More s390x improvements

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/5] More s390x improvements
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
06496cb target/s390x: mark CSST, CSST2, FPSEH facilities as available
bb1f675 target/s390x: implement mvcos instruction
b29035d target/s390x: change PSW_SHIFT_KEY
9e51d0b target/s390x: Enforce instruction features
340d22d target/s390x: Map existing FAC_* names to S390_FEAT_* names

=== OUTPUT BEGIN ===
Checking PATCH 1/5: target/s390x: Map existing FAC_* names to S390_FEAT_* 
names...
WARNING: line over 80 characters
#71: FILE: target/s390x/translate.c:5403:
+#define FAC_FPSSH       S390_FEAT_FLOATING_POINT_SUPPPORT_ENH /* 
FPS-sign-handling */

WARNING: line over 80 characters
#72: FILE: target/s390x/translate.c:5404:
+#define FAC_FPRGR       S390_FEAT_FLOATING_POINT_SUPPPORT_ENH /* 
FPR-GR-transfer */

ERROR: line over 90 characters
#76: FILE: target/s390x/translate.c:5408:
+#define FAC_IEEEE_SIM   S390_FEAT_FLOATING_POINT_SUPPPORT_ENH /* 
IEEE-exception-simulation */

WARNING: line over 80 characters
#85: FILE: target/s390x/translate.c:5417:
+#define FAC_LPP         S390_FEAT_SET_PROGRAM_PARAMETERS /* 
load-program-parameter */

total: 1 errors, 3 warnings, 74 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/5: target/s390x: Enforce instruction features...
Checking PATCH 3/5: target/s390x: change PSW_SHIFT_KEY...
Checking PATCH 4/5: target/s390x: implement mvcos instruction...
Checking PATCH 5/5: target/s390x: mark CSST, CSST2, FPSEH facilities as 
available...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden