[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines |
|
Date: |
Fri, 16 Jun 2017 17:55:30 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 16/06/2017 17:21, Thomas Huth wrote:
>> Why do you say they can't be moved? They can, and your series should
>> change nothing about it, thanks to what you're doing now with
>> CONFIG_KVM_IS_POSSIBLE (which was also done before with NEED_CPU_H).
> numa.c and balloon.c both use ram_addr_t (numa.c uses it directly, and
> balloon.c indirectly via the QEMUBalloonEvent typedef from the header).
> And ram_addr_t is currently target-specific - it depends on
> CONFIG_XEN_BACKEND. So this could break in certain subtle cases, e.g.
> when compiling on a 32-bit host with XEN enabled.
Can ram_addr_t be poisoned on target-independent files?
Paolo
- [Qemu-devel] [PATCH 2/7] include/exec/poison: Mark some CONFIG defines as poisoned, too, (continued)
- [Qemu-devel] [PATCH 2/7] include/exec/poison: Mark some CONFIG defines as poisoned, too, Thomas Huth, 2017/06/16
- [Qemu-devel] [PATCH 3/7] Move CONFIG_KVM related definitions to kvm_i386.h, Thomas Huth, 2017/06/16
- [Qemu-devel] [PATCH 4/7] include/exec/poison: Mark CONFIG_KVM as poisoned, too, Thomas Huth, 2017/06/16
- [Qemu-devel] [PATCH 5/7] cpu: Introduce a wrapper for tlb_flush() that can be used in common code, Thomas Huth, 2017/06/16
- [Qemu-devel] [PATCH 7/7] Makefile: Move bootdevice.o to common-obj-y, Thomas Huth, 2017/06/16
- [Qemu-devel] [PATCH 6/7] include/exec/poison: Mark CONFIG_SOFTMMU as poisoned, Thomas Huth, 2017/06/16
- Re: [Qemu-devel] [PATCH v2 0/7] Poison some more target-specific defines, Paolo Bonzini, 2017/06/16