[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation fr
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework |
Date: |
Sun, 18 Jun 2017 17:20:25 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Emilio G Cota writes:
> Some minor nits below.
> On Mon, Jun 12, 2017 at 17:54:09 +0300, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---
>> +/**
>> + * BreakpointHitType:
>> + * @BH_MISS: No hit
>> + * @BH_HIT_INSN: Hit, but continue translating instruction
>> + * @BH_HIT_TB: Hit, stop translating TB
>> + *
>> + * How to react to a breakpoint hit.
>> + */
>> +typedef enum BreakpointHitType {
>> + BH_MISS,
>> + BH_HIT_INSN,
>> + BH_HIT_TB,
>> +} BreakpointHitType;
> BH_MISS reads out loud to "Breakpoint Hit Miss"; that's quite
> counterintuitive.
> Similarly for the others (e.g. "breakpoint Hit Hit -- ??".
> Can we just do BP_{MISS,HIT,etc}? Thinking about it, perhaps BP_NONE is
> better than BP_MISS.
[...]
Will do.
Cheers,
Lluis
- Re: [Qemu-devel] [PATCH] translator mega-patch, (continued)
- Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework, Emilio G. Cota, 2017/06/15
- Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework, Lluís Vilanova, 2017/06/18
- Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework, Lluís Vilanova, 2017/06/18
- Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework, Lluís Vilanova, 2017/06/18
- Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework, Emilio G. Cota, 2017/06/19
- Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework, Lluís Vilanova, 2017/06/19
- Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework,
Lluís Vilanova <=
[Qemu-devel] [PATCH v6 4/6] target: [tcg] Redefine DISAS_* onto the generic translation framework (DJ_*), Lluís Vilanova, 2017/06/12
[Qemu-devel] [PATCH v6 6/6] target: [tcg, arm] Port to generic translation framework, Lluís Vilanova, 2017/06/12
[Qemu-devel] [PATCH v6 1/6] Pass generic CPUState to gen_intermediate_code(), Lluís Vilanova, 2017/06/12