[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: Fix race of image locking between sr
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH] migration: Fix race of image locking between src and dst |
|
Date: |
Mon, 19 Jun 2017 16:28:58 +0100 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Mon, Jun 19, 2017 at 04:27:53PM +0100, Peter Maydell wrote:
> On 19 June 2017 at 15:49, Daniel P. Berrange <address@hidden> wrote:
> > IIUC as well as fixing the race condition, you're also improving
> > error reporting by using qemu_file_set_error() which was not done
> > previously. Would be nice to mention that in the commit message
> > too if you respin for any other reason, but that's just a nit-pick
>
> I've added
> N.B. This commit includes a minor improvement to the error handling
> by using qemu_file_set_error().
>
> to the commit message -- is that OK or do you want to suggest a
> different wording?
That's fine with me.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|