[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: 181 does not work for all
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: 181 does not work for all formats |
Date: |
Mon, 26 Jun 2017 21:23:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 2017-06-26 21:17, John Snow wrote:
>
>
> On 06/21/2017 09:11 AM, Max Reitz wrote:
>> Test 181 only works for formats which support live migration (naturally,
>> as it is a live migration test). Disable it for all formats which do
>> not.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> tests/qemu-iotests/181 | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/qemu-iotests/181 b/tests/qemu-iotests/181
>> index e969a2a..f73ad5a 100755
>> --- a/tests/qemu-iotests/181
>> +++ b/tests/qemu-iotests/181
>> @@ -43,6 +43,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>> . ./common.qemu
>>
>> _supported_fmt generic
>> +# Formats that do not support live migration
>> +_unsupported_fmt qcow vdi vhdx vmdk vpc vvfat
>> _supported_proto generic
>> _supported_os Linux
>>
>>
>
> Does this come up elsewhere in iotests? I guess not often enough to
> justify some macro like formats_unmigratable.
Well, formats_no_backing might happen more often...
> Eh.
Don't want to volunteer? :-)
> Reviewed-by: John Snow <address@hidden>
Thanks!
Aaand applied to my block branch.
Max
signature.asc
Description: OpenPGP digital signature