[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 1/9] pci: Clean up error checking in pci_add_capa
From: |
Mao Zhongyi |
Subject: |
[Qemu-devel] [PATCH v7 1/9] pci: Clean up error checking in pci_add_capability() |
Date: |
Tue, 27 Jun 2017 14:16:47 +0800 |
On success, pci_add_capability2() returns a positive value. On
failure, it sets an error and return a negative value.
pci_add_capability() laboriously checks this behavior. No other
caller does. Drop the checks from pci_add_capability().
Cc: address@hidden
Cc: address@hidden
Signed-off-by: Mao Zhongyi <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
---
hw/pci/pci.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 98ccc27..53566b8 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2270,12 +2270,8 @@ int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
Error *local_err = NULL;
ret = pci_add_capability2(pdev, cap_id, offset, size, &local_err);
- if (local_err) {
- assert(ret < 0);
+ if (ret < 0) {
error_report_err(local_err);
- } else {
- /* success implies a positive offset in config space */
- assert(ret > 0);
}
return ret;
}
--
2.9.4
- [Qemu-devel] [PATCH v7 0/9] Convert to realize and cleanup, Mao Zhongyi, 2017/06/27
- [Qemu-devel] [PATCH v7 3/9] pci: Fix the wrong assertion., Mao Zhongyi, 2017/06/27
- [Qemu-devel] [PATCH v7 4/9] pci: Make errp the last parameter of pci_add_capability(), Mao Zhongyi, 2017/06/27
- [Qemu-devel] [PATCH v7 1/9] pci: Clean up error checking in pci_add_capability(),
Mao Zhongyi <=
- [Qemu-devel] [PATCH v7 8/9] i386/kvm/pci-assign: Fix return type of verify_irqchip_kernel(), Mao Zhongyi, 2017/06/27
- [Qemu-devel] [PATCH v7 7/9] pci: Convert shpc_init() to Error, Mao Zhongyi, 2017/06/27
- [Qemu-devel] [PATCH v7 6/9] pci: Convert to realize, Mao Zhongyi, 2017/06/27
- [Qemu-devel] [PATCH v7 5/9] pci: Replace pci_add_capability2() with pci_add_capability(), Mao Zhongyi, 2017/06/27
- [Qemu-devel] [PATCH v7 9/9] i386/kvm/pci-assign: Use errp directly rather than local_err, Mao Zhongyi, 2017/06/27
- [Qemu-devel] [PATCH v7 2/9] pci: Add comment for pci_add_capability2(), Mao Zhongyi, 2017/06/27