[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 04/26] target: [tcg] Add generic translation
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v9 04/26] target: [tcg] Add generic translation framework |
Date: |
Tue, 27 Jun 2017 10:23:38 +0100 |
On 27 June 2017 at 04:22, Richard Henderson <address@hidden> wrote:
> On 06/26/2017 11:21 AM, Peter Maydell wrote:
>>
>> x86 definitely gets this totally wrong. I would be unsurprised
>> to find that other variable-length-insn targets do too.
>
>
> For x86, doing this optimally is difficult. We *could* fix it simply by
> single-stepping when executing within the last 15 bytes of the page.
My feeling is that the "longjump out of translate.c on insn aborts"
approach is pretty confusing and ideally we should get rid of that
entirely in favour of having the translate code handle an error
return from the "load byte/short/word" functions it calls. That might
then make it easier to bail out on page-crossing instructions.
thanks
-- PMM
Re: [Qemu-devel] [PATCH v9 04/26] target: [tcg] Add generic translation framework, Emilio G. Cota, 2017/06/26
Re: [Qemu-devel] [PATCH v9 04/26] target: [tcg] Add generic translation framework, Emilio G. Cota, 2017/06/26
Re: [Qemu-devel] [PATCH v9 04/26] target: [tcg] Add generic translation framework, Richard Henderson, 2017/06/26
[Qemu-devel] [PATCH v9 05/26] target: [tcg] Redefine DISAS_* onto the generic translation framework (DJ_*), Lluís Vilanova, 2017/06/25
[Qemu-devel] [PATCH v9 06/26] target: [tcg, i386] Port to DisasContextBase, Lluís Vilanova, 2017/06/25