[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 01/14] pc-bios/s390-ccw: Add the libc from t
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [RFC PATCH 01/14] pc-bios/s390-ccw: Add the libc from the SLOF firmware |
Date: |
Wed, 28 Jun 2017 00:14:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 27.06.2017 17:32, David Hildenbrand wrote:
> On 27.06.2017 13:48, Thomas Huth wrote:
>> To be able to use some more advanced libc functions in the s390-ccw
>> firmware, like printf() and malloc(), we need a better libc here.
>> This patch adds the C library from the SLOF firmware (taken from
>> the SLOF commit ID 62674aabe20612a9786fa03e87cf6916ba97a99a). The
>> files are copied without modifications here and will be adapted for
>> the s390-ccw firmware by the next patch. I just removed the getopt()
>> and scanf()-like functions from the libc since we likely do not need
>> them in the s390-ccw firmware.
>>
>
> We have SLOF as a git submodule in roms/SLOF.
>
> I wonder if there would a way to avoid duplicating files.
>
> E.g. build s390x-ccw.img only if roms/SLOF is checked out and link/copy
> the right folder.
>
> Then, also the question regarding coding style is gone.
>
> Would something like that work?
Cool idea, I like it at a first glance. It might be possible ... but
that also creates a lot of dependencies, e.g. each time there is a
related change in the SLOF repository, you run into the problem that it
might affect the s390-ccw firmware, too. Not sure whether we really
always want to deal with that situation...
Thomas
- [Qemu-devel] [RFC PATCH 00/14] Implement network booting directly into the s390-ccw BIOS, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 03/14] pc-bios/s390-ccw: Add a write() function for stdio, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 02/14] pc-bios/s390-ccw: Start using the libc from SLOF, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 04/14] pc-bios/s390-ccw: Add implementation of sbrk(), Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 06/14] libnet: Remove remainders of netsave code, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 01/14] pc-bios/s390-ccw: Add the libc from the SLOF firmware, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 07/14] libnet: Rework error message printing, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 08/14] libnet: Refactor some code of netload() into a separate function, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 10/14] pc-bios/s390-ccw: Add timer code for the libnet, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 11/14] pc-bios/s390-ccw: Add virtio-net driver code, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 09/14] pc-bios/s390-ccw: Make the basic libnet code compilable, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 12/14] pc-bios/s390-ccw: Load file via an intermediate .INS file, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 13/14] pc-bios/s390-ccw: Allow loading to address 0, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 14/14] pc-bios/s390-ccw: Wire up the netload code, Thomas Huth, 2017/06/27
- [Qemu-devel] [RFC PATCH 05/14] pc-bios/s390-ccw: Add the TFTP network loading stack from SLOF, Thomas Huth, 2017/06/27
- Re: [Qemu-devel] [RFC PATCH 00/14] Implement network booting directly into the s390-ccw BIOS, Farhan Ali, 2017/06/27