On Fri 23 Jun 2017 02:46:57 PM CEST, Manos Pitsidianakis wrote:
+# @BlockdevOptionsThrottle:
+#
+# Driver specific block device options for Throttle
+#
I would put this earlier in the json file, together with the rest of the
BlockdevOptions* structs.
+# @throttling-group: the name of the throttling group to use
Why not call it simply "group" ?
+#
+# @options: BlockIOThrottle options
+# Since: 2.9
+##
+{ 'struct': 'BlockdevOptionsThrottle',
+ 'data': { 'throttling-group': 'str',
+ 'file' : 'BlockdevRef',
+ '*options' : 'BlockIOThrottle'
+ } }
Not sure if 'file' is the best name for the field ("child"?), but I'm
fine with it.