[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/8] virtio-9p: record element after sanity checks
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PULL 4/8] virtio-9p: record element after sanity checks |
Date: |
Thu, 29 Jun 2017 15:43:47 +0200 |
If the guest sends a malformed request, we end up with a dangling pointer
in V9fsVirtioState. This doesn't seem to cause any bug, but let's remove
this side effect anyway.
Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
---
hw/9pfs/virtio-9p-device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index 245abd8aaef1..3380bfc0c551 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -61,7 +61,6 @@ static void handle_9p_output(VirtIODevice *vdev, VirtQueue
*vq)
}
QEMU_BUILD_BUG_ON(sizeof(out) != 7);
- v->elems[pdu->idx] = elem;
len = iov_to_buf(elem->out_sg, elem->out_num, 0,
&out, sizeof(out));
if (len != sizeof(out)) {
@@ -70,6 +69,8 @@ static void handle_9p_output(VirtIODevice *vdev, VirtQueue
*vq)
goto out_free_req;
}
+ v->elems[pdu->idx] = elem;
+
pdu_submit(pdu, &out);
}
--
2.7.5
- [Qemu-devel] [PULL 0/8] 9pfs patches for 2.10 20170629, Greg Kurz, 2017/06/29
- [Qemu-devel] [PULL 1/8] 9pfs: local: remove: use correct path component, Greg Kurz, 2017/06/29
- [Qemu-devel] [PULL 2/8] 9pfs: local: Add support for custom fmode/dmode in 9ps mapped security modes, Greg Kurz, 2017/06/29
- [Qemu-devel] [PULL 4/8] virtio-9p: record element after sanity checks,
Greg Kurz <=
- [Qemu-devel] [PULL 3/8] 9pfs: replace g_malloc()+memcpy() with g_memdup(), Greg Kurz, 2017/06/29
- [Qemu-devel] [PULL 6/8] virtio-9p: break device if buffers are misconfigured, Greg Kurz, 2017/06/29
- [Qemu-devel] [PULL 5/8] virtio-9p: message header is 7-byte long, Greg Kurz, 2017/06/29
- [Qemu-devel] [PULL 7/8] xen-9pfs: disconnect if buffers are misconfigured, Greg Kurz, 2017/06/29
- [Qemu-devel] [PULL 8/8] 9pfs: handle transport errors in pdu_complete(), Greg Kurz, 2017/06/29
- Re: [Qemu-devel] [PULL 0/8] 9pfs patches for 2.10 20170629, Peter Maydell, 2017/06/29