[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: pass bdrv_* methods to
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: pass bdrv_* methods to bs->file by default |
|
Date: |
Thu, 29 Jun 2017 15:05:21 +0100 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, Jun 28, 2017 at 01:46:15AM +0300, Manos Pitsidianakis wrote:
> The following functions fail if bs->drv does not implement them:
>
> bdrv_probe_blocksizes
> bdrv_probe_geometry
> bdrv_truncate
> bdrv_has_zero_init
> bdrv_get_info
> bdrv_media_changed
> bdrv_eject
> bdrv_lock_medium
> bdrv_co_ioctl
>
> Instead, the call should be passed to bs->file if it exists, to allow
> filter drivers to support those methods without implementing them.
>
> Signed-off-by: Manos Pitsidianakis <address@hidden>
> ---
> block.c | 45 ++++++++++++++++++++++++++++++++++-----------
> block/io.c | 4 ++++
> 2 files changed, 38 insertions(+), 11 deletions(-)
Will you send a block/raw-format.c patch that removes the forwarding
functions that are no longer needed?
signature.asc
Description: PGP signature