[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64 |
Date: |
Thu, 29 Jun 2017 18:52:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
Am 29.06.2017 um 18:29 schrieb Eric Blake:
> On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote:
>> remove some copy/paste leftover, code seems sane.
>>
>
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>
> Double-sob seems odd.
Maybe that double SOB can be cleaned by qemu-trivial (cc'ed).
>
>> ---
>> tcg/tci.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
> Otherwise,
> Reviewed-by: Eric Blake <address@hidden>
>
Note from the author: it's not a copy/paste leftover, but was
there on purpose: that code part was simply never executed
before, and I only removed the TODO() statements from tested
code.
So you are the first one who found a test case. Congratulations.
Reviewed-by: Stefan Weil <address@hidden>
- [Qemu-devel] [PATCH 1/8] MAINTAINERS: update TCG entries, (continued)
- [Qemu-devel] [PATCH 1/8] MAINTAINERS: update TCG entries, Philippe Mathieu-Daudé, 2017/06/28
- [Qemu-devel] [PATCH 2/8] MAINTAINERS: update KVM entries, Philippe Mathieu-Daudé, 2017/06/28
- [Qemu-devel] [PATCH 3/8] MAINTAINERS: update Xen entry, Philippe Mathieu-Daudé, 2017/06/28
- [Qemu-devel] [PATCH 4/8] MAINTAINERS: update TCI entry, Philippe Mathieu-Daudé, 2017/06/28
- [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64, Philippe Mathieu-Daudé, 2017/06/28
- [Qemu-devel] [PATCH 6/8] tcg/tci: disable MTTCG if TCI is enabled, Philippe Mathieu-Daudé, 2017/06/28
- [Qemu-devel] [RFC PATCH 8/8] travis: remove tcg/tci job, Philippe Mathieu-Daudé, 2017/06/28
- [Qemu-devel] [RFC PATCH 7/8] tcg/tci: time to remove it :(, Philippe Mathieu-Daudé, 2017/06/28
- Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter), Thomas Huth, 2017/06/29