[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/23] hyperv fixes and enhancements
From: |
Roman Kagan |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/23] hyperv fixes and enhancements |
Date: |
Thu, 29 Jun 2017 20:58:20 +0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, Jun 29, 2017 at 05:20:30PM +0200, Igor Mammedov wrote:
> On Wed, 21 Jun 2017 19:24:01 +0300
> Roman Kagan <address@hidden> wrote:
>
> > This series applies miscellaneous fixes and enhancements to Hyper-V
> > emulation code in QEMU, and lays out the ground for VMBus devices.
>
> Series is a big random mix of cleanup/refactoring/new features
> which is hard to review due to mixed content of above
> within patches as well inter them.
>
> I suggest to split series in at least in 2
> 1: make cleanups/refactoring first
> and on top of this
> 2: add new features
Indeed, I started to realize this. I'll try to re-split better when
respinning.
> * hyperv_find_vcpu() with expensive lookup and related renaming
> might be not needed at all if local_apics[12/23] is used.
>
> *pls add in cover letter a link to public git repo where
> it would be possible to pull from for testing/review.
I'm in the process of setting it up, will include it next time.
> PS:
> if renaming, do it consistently.
> ex:
> vcpu_id -> vp_index touches only hyperv.c
> but leaves old naming in user of kvm_hv_sint_route_create(): hyperv_testdev.c
I strived for eventual consistency: no vcpu_id is left after the last
patch in the series. But it's probably harder to review patch by patch.
So I'll redo the way you suggest.
Thanks,
Roman.
- Re: [Qemu-devel] [PATCH v2 14/23] hyperv: qom-ify SynIC, (continued)
- [Qemu-devel] [PATCH v2 15/23] hyperv: block SynIC use in QEMU in incompatible configurations, Roman Kagan, 2017/06/21
- [Qemu-devel] [PATCH v2 16/23] hyperv: make overlay pages for SynIC, Roman Kagan, 2017/06/21
- [Qemu-devel] [PATCH v2 18/23] hyperv: add synic event flag signaling, Roman Kagan, 2017/06/21
- [Qemu-devel] [PATCH v2 19/23] hyperv: process SIGNAL_EVENT hypercall, Roman Kagan, 2017/06/21
- [Qemu-devel] [PATCH v2 20/23] hyperv: process POST_MESSAGE hypercall, Roman Kagan, 2017/06/21
- [Qemu-devel] [PATCH v2 21/23] hyperv_testdev: add SynIC message and event testmodes, Roman Kagan, 2017/06/21
- [Qemu-devel] [PATCH v2 22/23] MAINTAINERS: add myself and eyakovlev@ for hyperv*, Roman Kagan, 2017/06/21
- [Qemu-devel] [PATCH v2 23/23] hyperv: update copyright notices, Roman Kagan, 2017/06/21
- Re: [Qemu-devel] [PATCH v2 00/23] hyperv fixes and enhancements, Igor Mammedov, 2017/06/29
- Re: [Qemu-devel] [PATCH v2 00/23] hyperv fixes and enhancements,
Roman Kagan <=