[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 2/3] qemu-error: Implement a more generic error
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC v2 2/3] qemu-error: Implement a more generic error reporting |
Date: |
Thu, 29 Jun 2017 15:47:48 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 06/29/2017 02:42 PM, Alistair Francis wrote:
> This patch removes the exisinting error_vreport() function and replaces it
s/exisinting/existing/
> with a more generic vreport() function that takes an enum describing the
> information to be reported.
>
> As part of this change a report() function is added as well with the
> same capability.
>
> To maintain full compatibility the original error_report() function is
> maintained and no changes to the way errors are printed have been made.
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
>
> -void error_vreport(const char *fmt, va_list ap)
> +void vreport(report_types type, const char *fmt, va_list ap)
> {
> GTimeVal tv;
> gchar *timestr;
>
> + switch (type) {
> + case ERROR:
> + /* To maintin compatibility we don't add anything here */
s/maintin/maintain/
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature