[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE insns |
Date: |
Sun, 2 Jul 2017 15:18:04 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 2017-07-01 13:25, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/s390x/helper.h | 6 +
> target/s390x/mem_helper.c | 310
> +++++++++++++++++++++++++++++++++++++++++++++
> target/s390x/translate.c | 44 +++++++
> target/s390x/insn-data.def | 13 ++
> 4 files changed, 373 insertions(+)
>
...
> diff --git a/target/s390x/translate.c b/target/s390x/translate.c
> index e739525..9301daa 100644
> --- a/target/s390x/translate.c
> +++ b/target/s390x/translate.c
> @@ -2122,6 +2122,49 @@ static ExitStatus op_ct(DisasContext *s, DisasOps *o)
> return NO_EXIT;
> }
>
> +static ExitStatus op_cuXX(DisasContext *s, DisasOps *o)
> +{
> + int m3 = get_field(s->fields, m3);
> + TCGv_i32 r1 = tcg_const_i32(get_field(s->fields, r1));
> + TCGv_i32 r2 = tcg_const_i32(get_field(s->fields, r2));
> + TCGv_i32 chk;
> +
> + if (!s390_has_feat(s->insn->fac == S390_FEAT_EXTENDED_TRANSLATION_3
> + ? S390_FEAT_ETF3_ENH : S390_FEAT_ETF2_ENH)) {
> + m3 = 0;
> + }
This doesn't look correct to me. The well-formedness checking is part of
ETF3_ENH facility, for both convert unicode instructions that are part
of the Z architecture (CU12 and CU21) and for the ones added by the ETF3
facility (CU14 and CU24).
The rest of the patch now looks fine.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v2 0/8] target/s390x tcg patches, Richard Henderson, 2017/07/01
- [Qemu-devel] [PATCH v2 1/8] target/s390x: Implement CSST, Richard Henderson, 2017/07/01
- [Qemu-devel] [PATCH v2 4/8] target/s390x: Implement SRSTU, Richard Henderson, 2017/07/01
- [Qemu-devel] [PATCH v2 6/8] target/s390x: Mark ETF3 and ETF3_ENH facilities as available, Richard Henderson, 2017/07/01
- [Qemu-devel] [PATCH v2 7/8] target/s390x: Allow to enable "idtes" feature for TCG, Richard Henderson, 2017/07/01
- [Qemu-devel] [PATCH v2 3/8] target/s390x: Tidy SRST, Richard Henderson, 2017/07/01
- [Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE insns, Richard Henderson, 2017/07/01
- Re: [Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE insns,
Aurelien Jarno <=
- [Qemu-devel] [PATCH v2 5/8] target/s390x: Implement TRTR, Richard Henderson, 2017/07/01
- [Qemu-devel] [PATCH v2 8/8] target/s390x: Fix risbg handling, Richard Henderson, 2017/07/01