[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v1 01/17] disas/microblaze: Add missing 'const' attri
From: |
Edgar E. Iglesias |
Subject: |
[Qemu-devel] [PULL v1 01/17] disas/microblaze: Add missing 'const' attributes |
Date: |
Tue, 4 Jul 2017 11:54:32 +0200 |
From: Stefan Weil <address@hidden>
Making the opcode list 'const' saves memory.
Some function arguments and local variables needed 'const', too.
Add also 'static' to two local functions.
Reviewed-by: Edgar E. Iglesias <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
[EI: Removed old prototypes to fix the build]
Signed-off-by: Edgar E. Iglesias <address@hidden>
---
disas/microblaze.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/disas/microblaze.c b/disas/microblaze.c
index 7795a0b..598ecbc 100644
--- a/disas/microblaze.c
+++ b/disas/microblaze.c
@@ -272,7 +272,7 @@ enum microblaze_instr_type {
#define MAX_OPCODES 280
-static struct op_code_struct {
+static const struct op_code_struct {
const char *name;
short inst_type; /* registers and immediate values involved */
short inst_offset_type; /* immediate vals offset from PC? (= 1 for branches)
*/
@@ -596,10 +596,6 @@ static char * get_field_imm15 (long instr);
#if 0
static char * get_field_unsigned_imm (long instr);
#endif
-char * get_field_special (long instr, struct op_code_struct * op);
-unsigned long read_insn_microblaze (bfd_vma memaddr,
- struct disassemble_info *info,
- struct op_code_struct **opr);
static char *
get_field (long instr, long mask, unsigned short low)
@@ -664,8 +660,8 @@ get_field_unsigned_imm (long instr)
}
*/
-char *
-get_field_special (long instr, struct op_code_struct * op)
+static char *
+get_field_special(long instr, const struct op_code_struct *op)
{
char tmpstr[25];
char spr[6];
@@ -729,14 +725,14 @@ get_field_special (long instr, struct op_code_struct * op)
return(strdup(tmpstr));
}
-unsigned long
+static unsigned long
read_insn_microblaze (bfd_vma memaddr,
struct disassemble_info *info,
- struct op_code_struct **opr)
+ const struct op_code_struct **opr)
{
unsigned char ibytes[4];
int status;
- struct op_code_struct * op;
+ const struct op_code_struct *op;
unsigned long inst;
status = info->read_memory_func (memaddr, ibytes, 4, info);
@@ -772,7 +768,7 @@ print_insn_microblaze (bfd_vma memaddr, struct
disassemble_info * info)
fprintf_function fprintf_func = info->fprintf_func;
void * stream = info->stream;
unsigned long inst, prev_inst;
- struct op_code_struct * op, *pop;
+ const struct op_code_struct *op, *pop;
int immval = 0;
bfd_boolean immfound = FALSE;
static bfd_vma prev_insn_addr = -1; /*init the prev insn addr */
--
2.7.4
- [Qemu-devel] [PULL v1 00/17] Xilinx queue, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 04/17] target-microblaze: Add CPU versions 9.4, 9.5 and 9.6, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 02/17] target-microblaze: Correct bit shift for the PVR0 version field, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 01/17] disas/microblaze: Add missing 'const' attributes,
Edgar E. Iglesias <=
- [Qemu-devel] [PULL v1 03/17] target-microblaze: Don't hard code 0xb as initial MB version, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 05/17] target-microblaze: Introduce a use-barrel property, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 06/17] target-microblaze: Introduce a use-div property, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 07/17] target-microblaze: Introduce a use-hw-mul property, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 09/17] target-microblaze: Introduce a use-pcmp-instr property, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 10/17] target-microblaze: dec_barrel: Use bool instead of unsigned int, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 11/17] target-microblaze: dec_barrel: Use extract32, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 13/17] target-microblaze: dec_barrel: Plug TCG temp leak, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 08/17] target-microblaze: Introduce a use-msr-instr property, Edgar E. Iglesias, 2017/07/04
- [Qemu-devel] [PULL v1 12/17] target-microblaze: dec_barrel: Add braces around if-statements, Edgar E. Iglesias, 2017/07/04