[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/22] configure: early test for supported targe
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 02/22] configure: early test for supported targets |
Date: |
Tue, 4 Jul 2017 13:08:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 04/07/2017 10:32, Daniel P. Berrange wrote:
>> if test -z "${target_list+xxx}" ; then
>> - target_list="$default_target_list"
>> + for target in $default_target_list; do
>> + supported_target $target 2>/dev/null && \
>> + target_list="$target_list $target"
>> + done
>
> I'm not sure what the benefit of this change is ? It is calling
> supported_target but throwing away anything it prints. So if there
> was a mistake in the default target list setup, we'd never see it,
> just silently discard it.
As of this patch there is no benefit, but it is what makes patch 3 drop
non-hardware-accelerated targets for --disable-tcg.
Paolo