[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 02/20] trace: Show blockjob actions via bytes
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 02/20] trace: Show blockjob actions via bytes, not sectors |
Date: |
Tue, 4 Jul 2017 17:28:20 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.06.2017 um 21:24 hat Eric Blake geschrieben:
> Upcoming patches are going to switch to byte-based interfaces
> instead of sector-based. Even worse, trace_backup_do_cow_enter()
> had a weird mix of cluster and sector indices.
>
> The trace interface is low enough that there are no stability
> guarantees, and therefore nothing wrong with changing our units,
> even in cases like trace_backup_do_cow_skip() where we are not
> changing the trace output. So make the tracing uniformly use
> bytes.
>
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: John Snow <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 02/20] trace: Show blockjob actions via bytes, not sectors,
Kevin Wolf <=