[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/35] coroutine: remove coroutine_fn from qemu_
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/35] coroutine: remove coroutine_fn from qemu_coroutine_self() |
|
Date: |
Wed, 5 Jul 2017 15:43:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 05/07/2017 15:39, Marc-André Lureau wrote:
>>> The function may be safely called from non-coroutine context.
>>>
>>> Signed-off-by: Marc-André Lureau <address@hidden>
>> It can, but it shouldn't... What are the callers?
>
> There is aio_co_enter() & qemu_aio_coroutine_enter() that call it
> without coroutine context, but they are probably safe and can be
> manually tagged as coroutine-section.
Yes, they are. One is under qemu_in_coroutine (patch 2), the other is
part of the runtime (patch 1 maybe).
Awesome work by the way.
Paolo