[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are corouti
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn |
Date: |
Wed, 5 Jul 2017 18:42:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 05/07/2017 18:40, Marc-André Lureau wrote:
> Hi
>
> ----- Original Message -----
>>
>>
>> On 05/07/2017 18:06, Marc-André Lureau wrote:
>>>>> coroutine_fn too)
>>>> It's not controversial, I would not have expected the functions to call
>>>> coroutine_fn. :) How do they do that?
>>>>
>>> For example, null_co_readv() calls null_co_common() which calls
>>> co_aio_sleep_ns()
>>
>> But these are bdrv_co_*, not bdrv_aio_*.
>
> Oops, right.
>
> Indeed, it's not needed, but to avoid coroutine annotation mismatch, we would
> have to remove a few:
>
> static coroutine_fn BlockAIOCB *raw_aio_pdiscard(BlockDriverState *bs,
>
> static coroutine_fn BlockAIOCB *hdev_aio_pdiscard(BlockDriverState *bs,
>
> Only those 2, it seems.
Good! If it's just those two, they are wrong indeed. I'd be surprised
to see more (and even more surprised to see that the annotations were
right :)).
Paolo
- Re: [Qemu-devel] [PATCH 06/35] coroutine: mark CoRwLock coroutine_fn, (continued)
- [Qemu-devel] [PATCH 07/35] blockjob: mark coroutine_fn, Marc-André Lureau, 2017/07/04
- [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/04
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn,
Paolo Bonzini <=
[Qemu-devel] [PATCH 09/35] block: bdrv_create() and bdrv_debug_event() are coroutine_fn, Marc-André Lureau, 2017/07/04
[Qemu-devel] [PATCH 11/35] qcow2: mark coroutine_fn, Marc-André Lureau, 2017/07/04
[Qemu-devel] [PATCH 10/35] vmdk: mark coroutine_fn, Marc-André Lureau, 2017/07/04
[Qemu-devel] [PATCH 12/35] raw: mark coroutine_fn, Marc-André Lureau, 2017/07/04
[Qemu-devel] [PATCH 14/35] migration: mark coroutine_fn, Marc-André Lureau, 2017/07/04