[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 23/29] target/arm: [tcg] Port to translate_i
Re: [Qemu-devel] [PATCH v11 23/29] target/arm: [tcg] Port to translate_insn
Fri, 7 Jul 2017 07:38:26 -1000
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
On 07/07/2017 07:18 AM, Lluís Vilanova wrote:
There was no code being generated after this specific case, but I haven't
checked if DISAS_EXC is set in any other place that is not immediately followed
by a "goto done_generating".
Typically we haven't actually done a goto, but simply exit the loop and emit
nothing within the final cleanup (tb_stop?).
Does this mean DISAS_EXC should be on the generic code and do a "goto
done_generating" whenever it is found? And if so, what are the correct places to
check for this? After ops->insn_start, ops->translate_insn, ops->tb_stop?
Yes, this should be handled generically, since all targets need it.
That said, I would prefer a better name like DISAS_NORETURN, which does not
imply that an actual exception has been raised, but explicitly says that all
following code is dead.