[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_d

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap
Date: Mon, 10 Jul 2017 17:08:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 10/07/2017 17:07, Stefan Hajnoczi wrote:
> On Wed, Jul 05, 2017 at 09:36:32PM +0800, Fam Zheng wrote:
>> Allow block driver to map and unmap a buffer for later I/O, as a performance
>> hint.
> The name blk_dma_map() is confusing since other "dma" APIs like
> dma_addr_t and dma_blk_io() deal with guest physical addresses instead
> of host addresses.  They are about DMA to/from guest RAM.
> Have you considered hiding this cached mapping in block/nvme.c so that
> it isn't exposed?  block/nvme.c could keep the last buffer mapped and
> callers would get the performance benefit without a new blk_dma_map()
> API.

One buffer is enough for qemu-img bench, but not for more complex cases
(e.g. fio).


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]