[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 12/18] crypto: introduce some common function
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v4 12/18] crypto: introduce some common functions for af_alg backend |
Date: |
Tue, 11 Jul 2017 13:28:02 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Jul 04, 2017 at 04:57:04PM +0800, Longpeng(Mike) wrote:
> The AF_ALG socket family is the userspace interface for linux
> crypto API, this patch adds af_alg family support and some common
> functions for af_alg backend. It'll be used by afalg-backend crypto
> latter.
>
> Signed-off-by: Longpeng(Mike) <address@hidden>
> ---
> configure | 22 ++++++++++
> crypto/Makefile.objs | 1 +
> crypto/afalg.c | 118
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> crypto/afalgpriv.h | 55 ++++++++++++++++++++++++
> 4 files changed, 196 insertions(+)
> create mode 100644 crypto/afalg.c
> create mode 100644 crypto/afalgpriv.h
>
> diff --git a/crypto/afalgpriv.h b/crypto/afalgpriv.h
> new file mode 100644
> index 0000000..d21160c
> --- /dev/null
> +++ b/crypto/afalgpriv.h
> @@ -0,0 +1,55 @@
> +
> +struct QCryptoAFAlg {
> + int tfmfd;
> + int opfd;
> + char *name;
What actually uses this 'name' field ? I'm not seing anything in the
patch series that ever reads it, once set. So can we just delete it
perhaps ?
> + struct msghdr *msg;
> + struct cmsghdr *cmsg;
> +};
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v4 10/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for glib-backend, (continued)
- [Qemu-devel] [PATCH v4 10/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for glib-backend, Longpeng(Mike), 2017/07/04
- [Qemu-devel] [PATCH v4 07/18] crypto: hmac: move crypto/hmac.h into include/crypto/, Longpeng(Mike), 2017/07/04
- [Qemu-devel] [PATCH v4 04/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for builtin-backend, Longpeng(Mike), 2017/07/04
- [Qemu-devel] [PATCH v4 18/18] tests: crypto: add hmac speed benchmark support, Longpeng(Mike), 2017/07/04
- [Qemu-devel] [PATCH v4 15/18] crypto: hmac: add af_alg hmac support, Longpeng(Mike), 2017/07/04
- [Qemu-devel] [PATCH v4 17/18] tests: crypto: add hash speed benchmark support, Longpeng(Mike), 2017/07/04
- [Qemu-devel] [PATCH v4 05/18] crypto: cipher: add cipher driver framework, Longpeng(Mike), 2017/07/04
- [Qemu-devel] [PATCH v4 16/18] tests: crypto: add cipher speed benchmark support, Longpeng(Mike), 2017/07/04
- [Qemu-devel] [PATCH v4 12/18] crypto: introduce some common functions for af_alg backend, Longpeng(Mike), 2017/07/04
- Re: [Qemu-devel] [PATCH v4 12/18] crypto: introduce some common functions for af_alg backend,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v4 13/18] crypto: cipher: add afalg-backend cipher support, Longpeng(Mike), 2017/07/04
- [Qemu-devel] [PATCH v4 14/18] crypto: hash: add afalg-backend hash support, Longpeng(Mike), 2017/07/04
- Re: [Qemu-devel] [PATCH v4 00/18] crypto: add afalg-backend support, Daniel P. Berrange, 2017/07/06