qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] Fix qemu-bridge-helper with SUID


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH 0/3] Fix qemu-bridge-helper with SUID
Date: Tue, 11 Jul 2017 15:54:56 +0100
User-agent: Mutt/1.8.0 (2017-02-23)

On Tue, Jul 11, 2017 at 03:10:43PM +0200, Michal Privoznik wrote:
> On 06/22/2017 05:58 PM, Michal Privoznik wrote:
> > On 05/30/2017 10:23 AM, Michal Privoznik wrote:
> >> For more description see patch 3. Long story short, if the bridge helper 
> >> runs
> >> with SUID, the mechanism we rely on (DAC denying access to ACL files) does 
> >> not
> >> work.
> >>
> >> Michal Privoznik (3):
> >>   qemu-bridge-helper: Reverse return value setting logic
> >>   qemu-bridge-helper: Reverse return value setting logic in
> >>     parse_acl_file
> >>   qemu-bridge-helper: Take ACL file gid into account
> >>
> >>  qemu-bridge-helper.c | 79 
> >> ++++++++++++++++++++++++++++------------------------
> >>  1 file changed, 42 insertions(+), 37 deletions(-)
> >>
> > 
> > ping?
> > 
> 
> ping^2?

Sigh, this is one of the files for which we have no nominated maintainer
listed, so it easily falls through the cracks.

Since this is network related, I wonder if Jason should be listed in the
MAINTAINERS file for this. Or perhaps we should move the qemu-bridge-helper.c
file into the net/ sub-directory instead ?

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]