[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/7] dump: add vmcoreinfo ELF note
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/7] dump: add vmcoreinfo ELF note |
Date: |
Tue, 11 Jul 2017 17:14:57 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Jul 11, 2017 at 10:04:43PM +0200, Laszlo Ersek wrote:
[...]
> > + lines = g_strsplit((char *)vmci, "\n", -1);
> > + for (i = 0; lines[i]; i++) {
> > + if (g_str_has_prefix(lines[i], "NUMBER(phys_base)=")) {
> > + if (qemu_strtou64(lines[i] + 18, NULL, 16,
> > + &phys_base) < 0) {
> > + error_report("warning: Failed to read NUMBER(phys_base)=");
[...]
> > + } else if (size < note_head_size || size > MAX_VMCOREINFO_SIZE) {
> > + error_report("warning: vmcoreinfo size is invalid: %" PRIu32,
> > size);
[...]
> > + error_report("warning: Invalid vmcoreinfo header");
You will probably want to change this to warn_report() once
Alistair's series is merged.
--
Eduardo
- [Qemu-devel] [PATCH v3 0/7] KASLR kernel dump support, Marc-André Lureau, 2017/07/11
- [Qemu-devel] [PATCH v3 1/7] vmgenid: replace x-write-pointer-available hack, Marc-André Lureau, 2017/07/11
- [Qemu-devel] [PATCH v3 2/7] acpi: add vmcoreinfo device, Marc-André Lureau, 2017/07/11
- [Qemu-devel] [PATCH v3 3/7] tests: add simple vmcoreinfo test, Marc-André Lureau, 2017/07/11
- [Qemu-devel] [PATCH v3 4/7] dump: add vmcoreinfo ELF note, Marc-André Lureau, 2017/07/11
- [Qemu-devel] [PATCH v3 5/7] kdump: add vmcoreinfo ELF note, Marc-André Lureau, 2017/07/11
- [Qemu-devel] [PATCH v3 6/7] scripts/dump-guest-memory.py: add vmcoreinfo, Marc-André Lureau, 2017/07/11
[Qemu-devel] [PATCH v3 7/7] MAINTAINERS: add Dump maintainers, Marc-André Lureau, 2017/07/11
Re: [Qemu-devel] [PATCH v3 0/7] KASLR kernel dump support, no-reply, 2017/07/11
Re: [Qemu-devel] [PATCH v3 0/7] KASLR kernel dump support, Laszlo Ersek, 2017/07/11