[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] slirp: Handle error returns from sosendoob(
Re: [Qemu-devel] [PATCH 2/2] slirp: Handle error returns from sosendoob()
Tue, 11 Jul 2017 21:38:28 +0100
On 11 July 2017 at 19:46, Dr. David Alan Gilbert <address@hidden> wrote:
> * Peter Maydell (address@hidden) wrote:
>> sosendoob() can return a failure code, but all its callers ignore it.
>> This is OK in sbappend(), as the comment there states -- we will try
>> again later in sowrite(). Add a (void) cast to tell Coverity so.
>> In sowrite() we do need to check the return value -- we should handle
>> a write failure in sosendoob() the same way we handle a write failure
>> for the normal data.
>> Signed-off-by: Peter Maydell <address@hidden>
> I think this is OK, I do have one worry, which is perhaps there
> were errors previously that would just loose OOB but get silently
> ignored that perhaps we survived OK.
> There's a comment there about seeing EAGAIN or EINTR in the normal
> data path and not erroring; hopefully we don't in the OOB case?
Let's hope :-) This way round at least we'll find out if
we ever do.
> However, it generally seems to be sane, so:
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>